Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new EPOXY_CORE_PATH override to select ESP8266 core provided by this project #3

Merged
merged 4 commits into from
Apr 29, 2021
Merged

Use new EPOXY_CORE_PATH override to select ESP8266 core provided by this project #3

merged 4 commits into from
Apr 29, 2021

Conversation

bxparks
Copy link
Collaborator

@bxparks bxparks commented Apr 12, 2021

In bxparks/EpoxyDuino#29, I added the ability for an end-user to specify a different Arduino core than the one supplied by EpoxyDuino. The variable EPOXY_CORE_PATH in a Makefile overrides the default.

I updated the Core files in EspMock to become self-contained. I removed and changed a bunch of unnecessary files. Then I updated tests/network-tests/Makefile to point the Core files hosted in this project, like this:

APP_NAME := network-tests
ARDUINO_LIBS := AUnit TinyMqtt EspMock ESP8266WiFi
ARDUINO_LIB_DIRS := ../../libraries
EPOXY_CORE_PATH := ../../cores/esp8266
include ../../../EpoxyDuino/EpoxyDuino.mk

Seems to work.

I will provide more details in bxparks/EpoxyDuino#27.

@hsaturn
Copy link
Owner

hsaturn commented Apr 13, 2021

Note: Auto checks have failed.

At first (and very fast) glance, I think that this PR make a hudge duplicates code.

Arduino.cpp: same file
avr_stdlib.cpp: same file
avr_stdlib.h: same file
IPAddress.cpp: same file
IPAddress.h: same file
main.cpp: same file
pgmspace.h: same file
Printable.h: same file
Print.cpp: same file
Print.h: same file
StdioSerial.cpp: same file
StdioSerial.h: same file
Stream.cpp: same file
Stream.h: same file
WCharacter.h: same file
WString.cpp: same file
WString.h: same file

I think that using at max at possible the same source is better.
Main differences in fact are pins definition and some interrupts or ADC things.
Lot of things are common for all platforms, especially for just a Mock.

I'll take time tomorrow to study more longer this PR.

Thanks Brian

@bxparks
Copy link
Collaborator Author

bxparks commented Apr 13, 2021

The tests will pass after bxparks/EpoxyDuino#29 is submitted.

@hsaturn
Copy link
Owner

hsaturn commented Apr 28, 2021

Hi Brian, still waiting for the #29 to be merged. Test are still in failure yet.

@bxparks bxparks merged commit 014ee53 into main Apr 29, 2021
@bxparks bxparks deleted the epoxy_core branch April 29, 2021 13:27
@bxparks
Copy link
Collaborator Author

bxparks commented Apr 29, 2021

Everything is submitted. I have updated the README.md with the latest instructions. Take a look at the changes I made to your tests/network-tests/Makefile. I added the EPOXY_CORE_PATH variable. And EspMock is no longer required in ARDUINO_LIBS. If you add additional mock libraries, keep adding them to the EspMock/libraries/ directory.

@hsaturn
Copy link
Owner

hsaturn commented Apr 29, 2021

Great !

I have ported my TinyMqtt library to Esp32 and was waiting for all these changes in order to be able to write some Aunit tests for the Esp32.

Thanks Brian

@bxparks bxparks mentioned this pull request Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bxparks @hsaturn